fix: address new save and follow issues #11102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
previously approved these changes
Nov 18, 2024
| } | ||
|
|
||
| export const ArtworkItemCTAs: React.FC<ArtworkItemCTAsProps> = ({ | ||
| artwork: artworkProp, | ||
| showSaveIcon = false, | ||
| // show follow icon by default, but allow it to be hidden on specific grids |
There was a problem hiding this comment.
Always better to use a JSDoc comment. Like this, it's visible in editors like VSCode.
Suggested change
| // show follow icon by default, but allow it to be hidden on specific grids | |
| /** | |
| * Show follow icon by default, but allow it to be hidden on specific grids | |
| */ |
MounirDhahri
previously approved these changes
Nov 18, 2024
artsyit
dismissed stale reviews from MounirDhahri and olerichter00
via
60ab3cc
dariakoko
added
the
Squash On Green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Followup on #11062
Address misalignments found during the QA session:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.